fix(instrumentation-dataloader): Patch batchLoadFn without creating an instance
#2498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
changed the title
batchLoadFn without creating an instancebatchLoadFn without creating an instance
3 tasks
onurtemizkan
force-pushed
the
dataloader-custom-methods
branch
from
6110fa8 to
acfeb34
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2498 +/- ##
==========================================
- Coverage 89.77% 89.76% -0.01%
==========================================
Files 187 187
Lines 9147 9149 +2
Branches 1884 1885 +1
==========================================
+ Hits 8212 8213 +1
- Misses 935 936 +1
🚀 New features to boost your workflow:
|
onurtemizkan
force-pushed
the
dataloader-custom-methods
branch
from
acfeb34 to
60d8499
Compare
trentm
requested changes
Nov 9, 2024
Contributor
trentm
left a comment
trentm
left a comment
There was a problem hiding this comment.
Mostly looks good, just a couple edge cases.
6 tasks
Member
Author
|
Hey @trentm, can I get another round of reviews, please? |
Member
|
cc @henrinormak (component-owner), please review if you find some time 🙂 |
trentm
approved these changes
Jun 26, 2025
Contributor
trentm
left a comment
trentm
left a comment
There was a problem hiding this comment.
Sorry for having dropped the ball on re-reviewing this.
LGTM.
I'll try to update and handle the merge conflict.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: getsentry/sentry-javascript#13869
Which problem is this PR solving?
DataLoaderconstructor forbatchLoadFn. This breaks the usage where theDataLoaderclass is extended.Short description of the changes
DataLoaderconstructor (which isbatchLoadFn) to patch to avoid creating an instance.